Skip to content

updated description of UPV components in tristan-isolde-unified-access-page#88

Open
IlyaTuzov wants to merge 2 commits intoopenhwgroup:mainfrom
IlyaTuzov:main
Open

updated description of UPV components in tristan-isolde-unified-access-page#88
IlyaTuzov wants to merge 2 commits intoopenhwgroup:mainfrom
IlyaTuzov:main

Conversation

@IlyaTuzov
Copy link
Copy Markdown

updated description of UPV components in tristan-isolde-unified-access-page

@davideschiavone
Copy link
Copy Markdown
Contributor

dear @IlyaTuzov , we are now working on the json version , can you please update these files? https://github.com/openhwgroup/tristan-isolde-unified-access-page/tree/main/ips

@IlyaTuzov
Copy link
Copy Markdown
Author

dear @IlyaTuzov , we are now working on the json version , can you please update these files? https://github.com/openhwgroup/tristan-isolde-unified-access-page/tree/main/ips

dear Davide, there is some failing check on this pull request, it says "Author Eclipse account cannot be found". I am not sure how to resolve it. Does is have something to do with the email linked to my github account.

@davideschiavone
Copy link
Copy Markdown
Contributor

davideschiavone commented Jul 21, 2025 via email

@IlyaTuzov
Copy link
Copy Markdown
Author

Dear Ilya, Please sign the ECA at: https://www.eclipse.org/legal/eca/

On Mon, Jul 21, 2025 at 12:30 PM Ilya Tuzov @.> wrote: IlyaTuzov left a comment (openhwgroup/tristan-isolde-unified-access-page#88) <#88 (comment)> dear @IlyaTuzov https://github.com/IlyaTuzov , we are now working on the json version , can you please update these files? https://github.com/openhwgroup/tristan-isolde-unified-access-page/tree/main/ips dear Davide, there is some failing check on this pull request, it says "Author Eclipse account cannot be found". I am not sure how to resolve it. Does is have something to do with the email linked to my github account. — Reply to this email directly, view it on GitHub <#88 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AENQYDJCOFIBDPFGMZ6BD5D3JS6N7AVCNFSM6AAAAACB7MDXU2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTAOJWGA4TAMBRGE . You are receiving this because you commented.Message ID: @. .com>
-- Best Davide Schiavone

Dear Davide,

I have registered in Eclipse and signed the ECA.
However, the pull request still fails some eclipse-related checks.
As a result, I can't neither pull nor push to the repository.

Best regards,
Ilya

@IlyaTuzov
Copy link
Copy Markdown
Author

Dear Ilya, Please sign the ECA at: https://www.eclipse.org/legal/eca/

On Mon, Jul 21, 2025 at 12:30 PM Ilya Tuzov @.> wrote: IlyaTuzov left a comment (openhwgroup/tristan-isolde-unified-access-page#88) <#88 (comment)> dear @IlyaTuzov https://github.com/IlyaTuzov , we are now working on the json version , can you please update these files? https://github.com/openhwgroup/tristan-isolde-unified-access-page/tree/main/ips dear Davide, there is some failing check on this pull request, it says "Author Eclipse account cannot be found". I am not sure how to resolve it. Does is have something to do with the email linked to my github account. — Reply to this email directly, view it on GitHub <#88 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AENQYDJCOFIBDPFGMZ6BD5D3JS6N7AVCNFSM6AAAAACB7MDXU2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTAOJWGA4TAMBRGE . You are receiving this because you commented.Message ID: _@**.**_ .com>
-- Best Davide Schiavone

Dear Davide,

I have registered in Eclipse and signed the ECA. However, the pull request still fails some eclipse-related checks. As a result, I can't neither pull nor push to the repository.

Best regards, Ilya

I granted Eclipse access to my github account.
Seem like it has resolved the problem. Now it passes the checks.
Thanks.

Copy link
Copy Markdown
Collaborator

@cairo-caplan cairo-caplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello Ilya,

Thank you for the PR and for successfully signing the ECA. I made some considerations regarding the text to be updated. Apart from the first, regarding the "NoC" name, feel free to implement (or not) the others.

Then, regarding the new JSON format for the Virtual Repository that @davideschiavone mentioned, currently it is only necessary for TRISTAN project files - I see your contributions are part of ISOLDE. That is still under discussion for ISOLDE and other projects, you can have a look at a model for the proposed JSON file for ISOLDE and give your feedback if you would like.

</td>
<td>
Not ready yet
<a href="https://gitlab.com/selene-riscv-platform/euros2pronoc/-/tree/AXI-MM-Network-Interface?ref_type=heads">NoC</a>
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For a name or label of the URL "NoC" is too generic, I would simply keep Wormhole NoC or change it to "euros2pronoc" or "osNoC: Open-Source Network-on-Chip" as indicated when you visit the repo

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, we can keep "Wormhole NoC".

</td>
<td>
TBD
This module monitors axi4 transactions and determines contention between the different initiators of transactions. The initiators of transactions are given by a world ID encoded in the QoS field of the AXI channels. Supports following contention tracking features: read contention monitoring backpressure channels, read contention blaming the head of the queue for all contention caused in the queue, cross read-write backpressure, write backpressure monitoring, cross write-read backpressure.
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would change "axi4"to "AXI4", but that is ok.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uppercase notation "AXI4" is better

</td>
<td>
&nbsp;
<a href="https://gitlab.com/selene-riscv-platform/DAVOS">BAFFI</a>
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here I would either the name or label of the URL to "DAVOS", or change the URL to "https://gitlab.com/selene-riscv-platform/DAVOS#1-bit-accurate-fpga-fault-injection-tool-baffi", as I understand BAFFI is one of the features of the DAVOS project

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@IlyaTuzov
Copy link
Copy Markdown
Author

I agree with all the comments. I also would like to add this info to the JSON.
How can I apply these changes? Since I can't nether pull nor push until this commit gets resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants